On 07/29/2014 05:42 PM, Jakub Hrozek wrote:
> From d597c5d7c6d1e312a8d1adac95f336deb0b1b135 Mon Sep 17
00:00:00 2001
> From: Nikolai Kondrashov <Nikolai.Kondrashov(a)redhat.com>
> Date: Mon, 28 Jul 2014 15:21:21 +0300
> Subject: [PATCH 6/6] build: Move libini_config 1.1.0 check to libini_config.m4
ACK, we just need to keep in mind that checking for libini must happen
before checking for Samba in the build system. But I guess a failed
build would tell us exactly :)
Yes, that's a drawback, but keeping all the checks in one place seems to still
be better to me so far.
I tested the patches on Fedora-20 and RHEL-6 (latest and oldest OS
releases we support). With libini 1.1 everything went fine, with stocke
RHEL-6.5 libini the build failed during configure phase.
I noticed the same problem on RHEL7, but it should be fixed by patch #3.
Thanks for the review, Jakub!
Sincerely,
Nick