-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 03/31/2010 09:48 PM, Stephen Gallagher wrote:
Nack.
The switch statement after is_logged_in() should check for ENOSYS and
print a warning that the status of the user cannot be determined on this
platform.
OK
Why are you passing KILL_CMD as an argument to KILL_CMD? I think this
is
probably a typo.
That's argv[0]
Failing to kick the user should be a survivable error. You should
probably warn loudly and proceed with the user deletion anyway.
Otherwise, you may end up in an inconsistent state (the account lock may
have worked, but the killall command failed, for example).
Currently we fail and return != EOK only if the usermod transaction
fails (in which case userdel would fail anyway) or the fork() call fails
(I wasn't sure if we should proceed in this case but I think we are in
enough trouble if we cannot fork). The return code of exec or killall is
not taken into account.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAku0TNoACgkQHsardTLnvCVkWwCgx2qLAjcnHS636LB2E7M5bFcQ
elgAoOQMKgftaHmTpaJc2cQOYh8kjpFj
=xy4Y
-----END PGP SIGNATURE-----