On Wed, Feb 17, 2016 at 01:54:56PM +0100, Lukas Slebodnik wrote:
On (21/01/16 18:23), Lukas Slebodnik wrote:
>On (21/01/16 17:30), Sumit Bose wrote:
>>On Thu, Jan 21, 2016 at 05:09:52PM +0100, Lukas Slebodnik wrote:
>>> ehlo,
>>>
>>> reason is explained in commit message.
>>> The intention for this patch was to a simplify spec file
>>> (at least a little bit :-)
>>>
>>> If we want to have some requirements for version of lib{ldb,tdb}
>>> then it would be better to have minimal required version in
>>> BuildRequires + configure detection of libraries.
>>> But it might be outdated if we use some ver ldb features.
>>>
>>> LS
>>
>>> From 275b260be7c4365668a7adeceee6e9e089ae2f42 Mon Sep 17 00:00:00 2001
>>> From: Lukas Slebodnik <lslebodn(a)redhat.com>
>>> Date: Thu, 21 Jan 2016 16:55:11 +0100
>>> Subject: [PATCH] SPEC: Remove unnecessary requirements
>>>
>>> We do not need to requires specific version of libldb
>>> or libtdb because it is automatically detected from
>>> binary/library dependencies. We also need never version
>>> of that libraries as it was specified in spec file.
>>>
>>> e.g.
>>> sh$ rpm -q --requires sssd-common | grep -E "TDB|LDB"
>>> libldb.so.1(LDB_0.9.10)(64bit)
>>> libtdb.so.1(TDB_1.2.1)(64bit)
>>>
>>> Our public libraries also provides version definitions
>>> therefore rpm can also detect minimal required version.
>>>
>>> sh$ rpm -q --requires sssd-common | grep -E "IDMAP"
>>> libsss_idmap.so.0(SSS_IDMAP_0.4)(64bit)
>>> sh$ $rpm -q --requires python-libsss_nss_idmap | grep -E
"IDMAP"
>>> libsss_nss_idmap.so.0(SSS_NSS_IDMAP_0.0.1)(64bit)
>>> sh$ rpm -q --requires sssd-ipa | grep -E "HBAC"
>>> libipa_hbac.so.0(IPA_HBAC_0.0.1)(64bit)
>>
>>I agree with the ldb and tbd changes.
>>
>>But iirc the other explicit version dependencies should take care that
>>the sssd packages are always install with the same version. E.g. if you
>>have a system with
>>
>>libsss_nss_idmap-1.13.3-1.fc23.x86_64 and
>>python3-libsss_nss_idmap-1.13.3-1.fc23.x86_64
>>
>>installed and call
>>
>>dnf update python3-libsss_nss_idmap-1.13.3-1.fc23.x86_64
>>
>>becasue there is a newer 1.13.3-2 SSSD release, I would expect that dnf
>>only updates python3-libsss_nss_idmap to 1.13.3-2 if you remove
>>"Requires: libsss_nss_idmap = %{version}-%{release}" form the package
>>definition because the library version dependency
>>"libsss_nss_idmap.so.0(SSS_NSS_IDMAP_0.0.1)" is still satisfied by
>>libsss_nss_idmap-1.13.3-1.fc23.x86_64. As a result you have
>>
>>libsss_nss_idmap-1.13.3-1.fc23.x86_64 and
>>python3-libsss_nss_idmap-1.13.3-2.fc23.x86_64
>>
>You might looks like irritating but if you want to update just one specific
>package then it will safe a badwith and speed-up process.
>But I do not insist on the change.
>
>Meanwhile I found a redundant dependency on sssd-common-pac.
> sssd -> sssd-ipa -> sssd-common-pac
> -> sssd-ad -> sssd-common-pac
> -> sssd-common-pac
>
>I want to remove as much as possible :-)
>
>Updated version is attached.
>
>LS
>From 870eba7bfd10b726fce9162afe2484f01c4bcd90 Mon Sep 17 00:00:00 2001
>From: Lukas Slebodnik <lslebodn(a)redhat.com>
>Date: Thu, 21 Jan 2016 16:55:11 +0100
>Subject: [PATCH] SPEC: Remove unnecessary requirements
>
>We do not need to requires specific version of libldb
>or libtdb because it is automatically detected from
>binary/library dependencies. We also need never version
>of that libraries as it was specified in spec file.
>
>e.g.
> sh$ rpm -q --requires sssd-common | grep -E "TDB|LDB"
> libldb.so.1(LDB_0.9.10)(64bit)
> libtdb.so.1(TDB_1.2.1)(64bit)
>
>There is also redundant dependency on sssd-common-pac
>sssd -> sssd-ipa -> sssd-common-pac
> -> sssd-ad -> sssd-common-pac
> -> sssd-common-pac
>
> sh$ rpm -q --whatrequires sssd-common-pac
> sssd-ipa-1.13.3-1.fc23.x86_64
> sssd-ad-1.13.3-1.fc23.x86_64
> sssd-1.13.3-1.fc23.x86_64
>---
> contrib/sssd.spec.in | 3 ---
> 1 file changed, 3 deletions(-)
BUMP
ACK (sorry for the delay)
bye,
Sumit
>
> LS
> _______________________________________________
> sssd-devel mailing list
> sssd-devel(a)lists.fedorahosted.org
>
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org