On Mon, 2011-12-19 at 11:36 -0500, Stephen Gallagher wrote:
On Mon, 2011-12-19 at 17:29 +0100, Jakub Hrozek wrote:
> On Wed, Dec 14, 2011 at 10:06:38PM -0500, Stephen Gallagher wrote:
> > This patch depends on the SIGCHLD patches currently under review. This
> > is the first consumer of those patches, and therefore can be used to
> > test them.
> >
> > This changes the behavior of the monitor's child-monitoring code to use
> > the new sigchld handler. It also replaces some useless loop-checks that
> > we were doing to verify that the process was still up using waitpid().
> > It's less wasteful to simply rely on SIGCHLD.
> >
> > I also revamped the restart logic so that now it will always restart
> > when the SIGCHLD handler is hit. To that end, I changed it so that the
> > ping timeout limit would kill the PID (thereby triggering the SIGCHLD
> > handler to take over).
> >
>
> Why was the logic to limit the number of service restarts removed? I
> think it can be useful for cases where a domain is badly misconfigured
> so that the monitor does not spin forever trying to restart a service.
>
Oops, that was an oversight. I forgot to add that back in. I'll get a
patch for this shortly.
New patch attached re-adds support for service startup limitation. I
tested it by setting 'command = /bin/false' in the [pam] section of
sssd.conf.