-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/23/2010 01:29 PM, Stephen Gallagher wrote:
Nack.
ldap_id_cleanup_users_done():
If the cleanup_groups_send subreq creation fails, you do not set
err. This means that the error you print will indicate EOK. That's
confusing to someone trying to debug. Also, please eliminate one or the
other of the DEBUG messages within the fail label. They are redundant.
Thanks for the review, new patch is attached.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkuDzx0ACgkQHsardTLnvCWIawCeONbTZrtkoR4zemLuX0mRkCML
rZkAn3GcxxNuqaq3tdpEJzvoAVDC+J1P
=kK02
-----END PGP SIGNATURE-----