On 11/04/2015 01:19 PM, Lukas Slebodnik wrote:
On (04/11/15 13:14), Pavel Reichl wrote:
> On 11/04/2015 12:53 PM, Jakub Hrozek wrote:
>>> From f9b5adc160d6c18c429cc4e12276896ccc6f7a6d Mon Sep 17 00:00:00 2001
>>> From: Pavel Reichl <preichl(a)redhat.com>
>>> Date: Tue, 20 Oct 2015 09:13:53 -0400
>>> Subject: [PATCH 3/3] TESTS: fix typo in PAM service name
>> What is the purpose of this patch? Just to match the service name with
>> what is on Fedora?
> My idea is that ssh daemon is the PAM service and not the ssh client no
> matter the system, right? IIRC it does not matter in this test at all but
> it's a typo anyway. I think I briefly asked Sumit about this change and he
> expressed his consensus however I can't find the conversation now so I can't
> But If you don't like the change feel free to drop it, it's no doubt a
You can have any file in /etc/pam.d
+1 for drop
I found the conversation I had with Sumit:
preichl> Hello Sumit, sorry to bother you again, I have just a
quick question - test_pam_srv.c mock_input_pam() - why do we set pi.pam_service =
"ssh"; ? Should not service be rather sshd? Thanks!
<preichl> I'm just curious I thought that sshd has pam modules...but I'm
afraid I forget even the little I already knew about PAM.
<sbose> no, you are right 'sshd' is the right service name, I guess it is
just a typo.
<preichl> OK, so if you don't mind I'll send a patch as part og the
patchset I'm working on
<sbose> no, of course not, go ahead