On Tue, May 12, 2015 at 09:55:53AM +0200, Jakub Hrozek wrote:
> It comes from sdap_get_generic_op_finished(). I was thinking
about
> adding special handling for LDAP_PROTOCOL_ERROR here, but I thought it
> might be too risky because it might break some other code which expects
> EIO.
>
> After you comment I did a "grep -r '== EIO' ../src/providers/*/*"
and
> found that there is only one other chekc for EIO and this is related to
> matching rules which are explicitly covered in
> sdap_get_generic_op_finished(). So I now think it is safe to add a
> special error code for this (and I will open a ticket to fix the code
> for the matching rule error as well :-).
Thank you for this thorough check, I guess I could have done it as a
part of the patch review myself.
With that covered -- ACK!
* master: a50b229c8ea1e22c9efa677760b94d8c48c3ec89
* sssd-1-12: 0f85298a31beb53375635b82cb274d29eae45774