On 10/01/2012 10:53 PM, Jakub Hrozek wrote:
On Thu, Sep 27, 2012 at 09:16:38PM +0200, Pavel Březina wrote:
> [PATCH 1/2]
> Fixes few coding style issues which I have found while digging the
> monitor code.
>
> [PATCH 2/2]
> Solves
https://fedorahosted.org/sssd/ticket/1357
>
> The pid file is now created after all responders are running.
>
> I have tested this by postponing responder initialization via sleep().
>
Yes, this works for me as well.
> I also found out that if a provider failed to start then every
> responder will fail to start as well, so the SSSD cannot provide data
> even from the cache. Ticket for this issue:
>
https://fedorahosted.org/sssd/ticket/1552
Ouch. Please let me know if you have enough cycles to fix that for 1.9.1
(due by Thursday). I think we should get the fix in.
> Subject: [PATCH 1/2] Fix few coding style issues
>
Ack
> Subject: [PATCH 2/2] monitor: create pid file after all responders are
> started
>
>
https://fedorahosted.org/sssd/ticket/1357
Ack as per functionality, but can you change the variable name from
"alive_services" to "started_services" or something like that?
alive_services implies periodical checking with pings rather than
one-time startup check.
Sure.
I wonder if the exit() is necessary? Would it be enough to just
return
the error code and perhaps also from client_registration() ?
When the pidfile was created in server_setup(), the monitor exited with
2, so I followed this scenario. But you are right. SSSD is fully
functional at this point so we shouldn't exit it just because we where
unable to create pidfile.
New patches are attached.