On Tue, Jan 06, 2015 at 01:38:21PM +0100, Pavel Březina wrote:
On 12/11/2014 12:01 PM, Jakub Hrozek wrote:
>Hi,
>
>attached are some small patches and most importantly unit tests I wrote
>recently when patching the child_common.c module.
>
>Please note that these patches shouldn't be applied until we split off
>the master branch from 1.12, but if I don't send them out before the
>Christmas break I'll forget completely :-)
Patch #1: ACK
Patch #2: ACK
Although, can you put the change that makes sss_child_handler static in a
separate commit as well? It doesn't seem to belong here.
Patch #3: ACK
Patch #4: ACK
Patch #5: ACK
Thanks for the review. I rebased the patches atop the current master,
added a test for the custom FD used for output and moved
sss_child_handler() to the first patch -- it seemed excessive to me to
have two patches just to make two functions static.