On (23/03/15 14:47), Pavel Reichl wrote:
On 03/23/2015 02:43 PM, Lukas Slebodnik wrote:
>On (23/03/15 14:18), Jakub Hrozek wrote:
>>On Mon, Mar 23, 2015 at 02:07:12PM +0100, Lukas Slebodnik wrote:
>>>ehlo,
>>>
>>>simple patch is attached.
>>>
>>>LS
>>Hm, the default CI test doesn't run distcheck?
>>
>>I admit I haven't ran distcheck myself, but was relying on the CI link
>>Pavel sent..
>That's the reason why I do not send link to CI result as an author of the
>patch.
>
>In my opinion it's reviewer's task.
>
>LS
What would be different if Jakub ran CI himself?
If I had reviewd your patch i would have sent links to CI result which
run all test (including distcheck and mock build)
I usually attach link to CI because I run it myself - to make sure
that my
patch is as tested as possible. I think it can save some unnecessary
turnarounds.
The main reason is that reviewer should not rely on CI link.
How can developer verify that CI link is for the same patches?
LS