Jan Zelený <jzeleny(a)redhat.com> wrote:
> On 04/15/2011 07:22 PM, Jan Zeleny wrote:
> > I'm sending corrected patch. I have one comment though.
> >
> > Jakub Hrozek <jhrozek(a)redhat.com> wrote:
> >> Allocation error is a serious one and should be handled.
> >
> > I don't think we should handle it differently (how?). After all it is
> > handled the same way like if allocation error occurred let's say in
> > sysdb_search_netgroups().
> >
> > Jan
>
> I think that if an OOM situation occurs, we should really just clean up
> and quit gracefully - in this case, do a sysdb_transaction_cancel();
Yes, but then we'd need to do this check after each call of a procedure
which might end up the same way, which is exactly what I'd like to avoid.
Jan
Here is a complete set of patches which are needed for the review.
Jan