On Sun, 2012-01-22 at 22:14 +0100, Jakub Hrozek wrote:
The attached patch requires the DP refactoring patch. It contains a
sudo-specific DP request.
A patch that actually uses the request in the sudo responder is being
tested now, but I wanted to get an early response on the approach.
Nack.
Based on my review of the sss_dp_issue_request() patch, this will need
updating to account for the hash key changes.
I'd rather see us start separating the different responder DP processing
into their own source files. I think this belongs in responder/sudo/. We
should reserve common for truly independent features (like the
sss_dp_issue_request()).
Also, when you call sss_dp_issue_request(), you're passing 'state' as
the pvt data for sss_dp_get_sudoers_msg(), but you meant to pass 'info',
I think.
Otherwise, this patch looks straightforward.