On 05/03/2010 05:07 PM, Jakub Hrozek wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 05/03/2010 10:02 PM, Stephen Gallagher wrote:
> Jakub noticed during review that I forgot to handle IPv6 addresses when
> retrieving the address from the LDAP connection.
>
> New patch attached.
Some minor nitpicks:
* Do we want to keep these new options undocumented? Ditto for ConfigAPI
No, I forgot to add the documentation. Upcoming patch will rectify this.
* The comment of NSUPDATE_PATH says "The patch to nscd"
Copy-paste fail.
* there is a new blank line added at the end of nsupdate.m4
Not sure what you mean here. It's a completely new file.
I haven't tested the patch yet but otherwise the patch looks good to me.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkvfOvgACgkQHsardTLnvCUgEwCfUtupw2z2GmE9kJxVxp2X61V6
PEUAn1qEYItYE6WuiCQMVVmCfLyXh3Dp
=WD5w
-----END PGP SIGNATURE-----
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel
--
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/