URL:
https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap
fidencio commented:
"""
- **intg: prevent "TypeError: must be type, not classobj":** Althought I
understand it would be out of the scope of this patch, but it could be fixed (not in the
same patch, but in the same series) also in:
- src/config/SSSDConfig/ipachangeconf.py:class IPAChangeConf:
- src/sbus/sbus_codegen:class Base:
- src/sbus/sbus_codegen:class DBusXMLParser:
- **intg: Let python paths be configurable:** ACK
- **intg: Add sanity tests for pysss_nss_idmap:** ACK
- **intg: Prefer locally built python modules:** ACK
- **ds_openldap: Extract functionality to protected methods:** ACK
- **intg: Create FakeAD class based on openldap:** Here I sincerely don't have enough
knowledge to tell whether it's right or not, but I trust the developer who wrote the
code ... so ACK (or someone else feel free to double-check this patch)
- **intg: Add sanity tests for pysss_nss_idmap:** ACK
Overall the series look good and, personally, I'd take advantage of this first patch
intention and also fix the very same issue in the three other places where it happens (and
I'm adding "Changes Requested" due to that).
Thanks for the series,
"""
See the full comment at
https://github.com/SSSD/sssd/pull/373#issuecomment-330160646