On Mon, Jan 18, 2016 at 01:53:27PM +0100, Sumit Bose wrote:
Thank you for the review. New version attached.
bye,
Sumit
Thank you, the patch now look good to me and seem to work well. I see
this message in adcli output:
! Couldn't set userAccountControl on computer account:
CN=ADCLIENT,CN=Computers,DC=win,DC=trust,DC=test: Insufficient access
but the keytab was updated successfully.
I also wonder if you considered using the -S option to run the update
against the server sssd talks to? From experience I know that many
environments restrict access to parts of their AD domain. It's not a big
deal, though, because failing to renew the keytab is non-fatal..
CI is OK:
http://sssd-ci.duckdns.org/logs/job/35/71/summary.html
and coverity is clean as well.