On 09/10/2009 04:42 PM, Simo Sorce wrote:
On Thu, 2009-09-10 at 16:18 -0400, Stephen Gallagher wrote:
>> mem_ctx is not used anymore in this function as far as I can see,
>> please remove it.
>
> It is still used for sysdb_init, so I left it there.
That sysdb_init() is used only to make sure the db is properly
initialized but the results are then discarded, we should probably
change the code to create a tmp_ctx right before running sysdb_init()
and then talloc_zfree(tmp_ctx) instead of the db_list.
This would also cause the mem_ctx to not be necessary anymore.
Simo.
Created a tmp_ctx around the sysdb_init and removed the mem_ctx from the
function. Also noticed a place where I forgot to remove a talloc_free(ctx).
--
Stephen Gallagher
RHCE 804006346421761
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/