On Thu, Jun 30, 2016 at 02:10:47PM +0200, Pavel Březina wrote:
> Failover patches for the sssctl tool. The output looks like:
>
> [master.ipa.pb: ~]$ sudo sssctl domain-status ad.pb
> Online status: Online
>
> Active servers:
> AD Global Catalog: root-dc.ad.pb
> AD Domain Controller: root-dc.ad.pb
> IPA: master.ipa.pb
>
> Discovered AD Global Catalog servers:
> - root-dc.ad.pb
> - invalid.ad.pb
> - root-dc.ad.pb
>
> Discovered AD Domain Controller servers:
> - root-dc.ad.pb
>
> Discovered IPA servers:
> - master.ipa.pb
>
> This is the best output format I could thing of so far, but I'm opened for
> suggestions.
I'm sorry for the late review. I started by sending the patches to CI
which found some failures:
http://sssd-ci.duckdns.org/logs/job/49/69/summary.html
and also Coverity complains:
Error: CHECKED_RETURN (CWE-252):
sssd-1.14.1/src/lib/sifp/sss_sifp_dbus.c:51: check_return: Calling
"dbus_message_append_args_valist" without checking return value (as is done
elsewhere 4 out of 5 times).
This was not caused by my patches since the code originates to 2014.
I fixed coverity warnings and CI.