On 04/30/2014 11:39 PM, Nikolai Kondrashov wrote:
On 04/30/2014 11:02 PM, Lukas Slebodnik wrote:
> I realised that sssd cannot be built after applying the 5th and the 6th patch.
> 0005-Make-DEBUG-macro-definition-variadic.patch
> 0006-Make-DEBUG-macro-invocations-variadic.patch
> It is fixed by the 7th patch.
> 0007-Fixup-DEBUG-macro-invocations-update.patch
>
> Now, it does not worth to modify patches, because the same problem is in
> master. I should have reviewed them. Just for the record.
> It is better to modify patches even if they are generated by script.
> It causes problem with bisecting. Sometimes problem can be solved easily.
> In my opinion, we should be able to compile each commit.
I understand the benefit of "every patch builds" approach and would support a
policy requiring that. Originally, I made them separate to simplify review
and left the squashing decision to maintainers. Here, I simply cherry-picked
them the way they were merged to (again) make it simpler.
One thing, though: having the script-generated patches separate certainly made
cherry-picking easier and faster.
Nick.