On Thu, Nov 01, 2012 at 02:07:51AM -0400, Simo Sorce wrote:
Hi all,
a few days ago I installed patchwork and an instance is tracking the
SSSD project here:
https://patchwork.acksyn.org/project/SSSD/list/
Although patchwork is not a full cycle review system it seem to work
really well for tacking patches and patchsets and their status.
The only limitation with patchwork is that it really only likes one
patch per email. This is why I switched fully to using git send-email
both for the freeIPA (tracked as well) and the SSSD project.
The advantage of using patchwork and git send-email is that it makes it
easier to track feedback per patch (replies to patches are captured by
patchwork) and because git send-email send the patch as plain email text
content it makes it very easy to comment inline in the patch to
highlight issues.
Some of the SSSD developers already registered into patchwork in order
to manage patches. Please feel free to register, in order to allow sssd
developers to manage patches from anyone I need to explicitly give
maintainership of the project (in patchwork) to your account otherwise
you are allowed only to change status about your own patches (so that
external contributors can handle their own if they so wish).
So feel free to send me an email if you register and need maintainer
status to start changing patch status.
At the moment the patchwork server is not yet hooked into the master git
tree, so it does not detect when patches are finally pushed. So once you
push a password please simply change the status to 'Pushed' (you may
also set the 'archive' bit but it is not required).
You can read more about patchwork following the 'about' link.
If you have any question or issue feel free to reply to this thread or
contact me directly.
Hi Simo,
I have a couple of questions:
* is there any way we could grant patch review rights to all SSSD
developers without granting them full admin rights? It seems to me
that admin rights should be restricted to the same group that
commits to git but everyone should be allowed to review
* saving patch files as opposed to saving the inline patches seemed
easier to me
* is it possible to group the patchsets together? Currently you sent
two patchsets, but I'm only able to distinguish them in patchwork
because I know one of them had 4 patches and the other had 5.
Ideally the patchwork interface would support threading.