On Wed, Jun 03, 2015 at 06:04:36PM +0200, Pavel Reichl wrote:
5th patch)
>>>+static void sdap_inherit_user_options(struct sss_domain_info *parent_dom,
>>>+ struct sdap_attr_map
>>>*parent_user_map,
>>>+ struct sdap_attr_map
>>>*child_user_map)
>>>+{
>>>+ int inherit_options[] = {
>>>+ SDAP_AT_USER_PRINC,
>>>+ SDAP_OPTS_USER /* sentinel */
>>>+ };
>>>+ int i;
>>>+
>>>+ for (i = 0; inherit_options[i] != SDAP_OPTS_USER; i++) {
>>>+ sdap_copy_map_entry(parent_user_map, child_user_map, i);
>>s/i/inherit_options[i] ?
>No, the parameter is an integer.
>
Yes, it's integer - I'd expect that you want to call:
sdap_copy_map_entry(parent_user_map, child_user_map, SDAP_AT_USER_PRINC) rather then
sdap_copy_map_entry(parent_user_map, child_user_map, 0)
I don't see what's the point of values of inherit_options at all if the code
would be right...I'll have another look tomorrow with fresh eyes.
Jakub it must be a typo - I can't resolve user from subdomain with patches applied,
but if I do the proposed change resolving of subdomain users starts to work.
Of course you're right, sorry.