On (08/12/14 13:58), Jakub Hrozek wrote:
Hi,
Coverity found an unused variable in the krb5_child code. After reading
the code again after a week it was written, I think we should do some
changes for better readability.
Mostly, fail on error from get_tgt_times() and change the flow so the
main branch (ie topmost indent) will be the success branch. It makes
sense to shortcut on success the first time get_tgt_times() is called to
check existing FAST ccache, but I think the second time, we expect
success, otherwise the forked child failed.
make sense
From 3ce7cf85d02dbdf3bc405191001b3bf4c3d208c9 Mon Sep 17 00:00:00
2001
From: Jakub Hrozek <jhrozek(a)redhat.com>
Date: Mon, 8 Dec 2014 13:29:23 +0100
Subject: [PATCH] KRB5: Check FAST kinit errors using get_tgt_times()
---
warning is fixed.
ACK
LS