On Tue, Nov 18, 2014 at 05:43:40PM +0100, Sumit Bose wrote:
On Tue, Nov 18, 2014 at 02:56:35PM +0100, Jakub Hrozek wrote:
> On Mon, Nov 17, 2014 at 06:35:57PM +0100, Sumit Bose wrote:
> > On Fri, Nov 14, 2014 at 01:52:20PM +0100, Jakub Hrozek wrote:
> > > On Thu, Nov 13, 2014 at 07:30:41PM +0100, Jakub Hrozek wrote:
> > > > On Wed, Nov 12, 2014 at 05:08:09PM +0100, Lukas Slebodnik wrote:
> > > >
> >
> > ...
> >
> > > > Thank you, see the attached patches.
> > >
> > > I forgot to remove the extra find_uid.c from Makefile.am
> >
> > I only have minor comments, see below. I understand that most part of
> > the patches are refactorings to make sure the related code is run with
> > the right permissions. (See next mail for some additional suggestions).
> >
> > The ccache handling always was delicate, e.g. directory creation with
> > DIR type and determine if FILE with _XXXXXX should be recreated or
> > reused. I run couple to tests without an issue but I think only
> > regression testing might give clarity here. So ACK from my side.
>
> Thank you for testing. Lukas was kind enough to run all available tests
> our QE has at their disposal related to Kerberos. I hope that raises the
> confidence level a bit.
>
> The attached patches fix all the issues you raised previously.
Thank you, ACK.
bye,
Sumit
* master:
35b4b217fa2b91bfc8d58c47024faf41c95fc807
2745b0156f12df7a7eb93d57716233243658e4d9
7c5cd2e7711621af9163a41393e88896a91ac33b
45aeb924ec3ac448bb8d174a5cc061ed98b147c7
476b78b3f66abc7a0f805154ea1a29f54628224a
a60f4bb6b321298eb4d1c1c33d1897049a83d357