-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/26/2010 05:33 PM, Stephen Gallagher wrote:
Nack.
This is partly my fault. update_monitor_config() is broken and dangerous. I thought I had disabled all access to it. I didn't realize it was still running with SIGHUP.
We disabled it a long while ago with the intent of fixing it eventually, but we ultimately decided that the downtime of a full restart was acceptable. I've been meaning to eliminate that code entirely.
Stephen eliminated that code in a separate patch which has been acked, so the attached patches are rebased on top of his.
Also, the *_rotate_logs() calls are all identical. They should just be made into a monitor_common_rotate_logs() call similar to monitor_common_res_init().
Done. I originally wanted to keep functions local to the separate process (and its function namespace) but I agree that code duplication is bad.