On Thu, 2012-11-01 at 17:36 +0100, Pavel Březina wrote:
+ if (ctx->is_daemon && ctx->parent_pid > 0
+ && ctx->parent_pid == getppid()) {
+ if (ctx->parent_pid <= 0 || ctx->parent_pid != getppid())
{
+ /* the parent process was already terminated */
+ DEBUG(SSSDBG_MINOR_FAILURE, ("Invalid parent pid
\n"));
+ goto done;
+ }
+
Isn't the second if condition redundant here ?
we can't even test it unless it is already true according to the
previous if () or am I missing something ?
Did you intend to use some || in the previous condition ?
Simo.
--
Simo Sorce * Red Hat, Inc * New York