On (26/08/16 13:16), Victor Tapia wrote:
Sorry for the late response, I've been out for nearly two weeks. I'm
attaching a new version of the patch to review.
> Does upstart/init script need to be updated as well?
> We have some generic in src/sysv/sssd.in
Upstart does need to keep track of the pidfile creation. I can't see a
service file, so I'll prepare one.
Regarding sysv, due to its sequential nature, it's dangerous to include
an infinite loop because it could stuck the normal boot of the machine.
I included a timeout in the loop to avoid this, please let me know what
you think about it.
> BTW the patch causes some failures for me on rhel6.
> According to logs, the file /var/run/sssd.pid
> did not exist in some cases.
> Please also remove changes in src/sysv/systemd/sssd.service.in
> in next version. For systemd only I would prefer "Type=notify".
Done, I've switched to Type=notify for systemd.
From 65f587535fae28719d3f2455fe144dd008361d52 Mon Sep 17 00:00:00
From: Victor Tapia <victor.tapia(a)canonical.com>
Date: Fri, 26 Aug 2016 13:01:32 +0200
Subject: [PATCH] Create pidfile after responders started
Makefile.am | 1 +
src/monitor/monitor.c | 42 ++++++++++++++++++++++++++++++++++++----
src/sysv/sssd.in | 11 +++++++++++
src/sysv/systemd/sssd.service.in | 3 ++-
4 files changed, 52 insertions(+), 5 deletions(-)
Thank you very much for updated version.
It will take me some time to test the patch.
But it's on my TODO list.