On (14/02/14 13:38), Pavel Březina wrote:
On 02/14/2014 01:01 PM, Lukas Slebodnik wrote:
>On (14/02/14 12:42), Pavel Březina wrote:
>>https://fedorahosted.org/sssd/ticket/2203
>
>>@@ -1951,6 +1954,9 @@ int sysdb_store_group(struct sss_domain_info *domain,
>> DEBUG(SSSDBG_MINOR_FAILURE,
>> "A group with the same GID [%llu] was removed from the
"
>> "cache\n", (unsigned long long) gid);
>>+ sss_log(SSS_LOG_WARNING, "A group with the same GID [%llu] was
"
>>+ "removed from the cache\n", (unsigned long long)
gid);
>Could you use macro SPRIuid instead of foramt string "%llu" and also remove
>explicit casting. (also in unchanged DEBUG message)
>
>Thank you
>
>LS
Done.
From 5d15e58d8ca04872f650e14910d579e8fc80e268 Mon Sep 17 00:00:00
2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrezina(a)redhat.com>
Date: Fri, 14 Feb 2014 12:39:13 +0100
Subject: [PATCH 1/2] sysdb: warn to syslog when removing object with same
uid/gid
Resolves:
https://fedorahosted.org/sssd/ticket/2203
---
src/db/sysdb_ops.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/db/sysdb_ops.c b/src/db/sysdb_ops.c
index a5dfd443c84b87609881f9042b3e82958c3b0e5f..92273b33ffcb1d637a222150fb9dfef6ef845431
100644
--- a/src/db/sysdb_ops.c
ACK for 1-11
From 3b3be590ee07bc566a3cffadf5073552a660aec0 Mon Sep 17 00:00:00
2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrezina(a)redhat.com>
Date: Fri, 14 Feb 2014 12:39:13 +0100
Subject: [PATCH] sysdb: warn to syslog when removing object with same uid/gid
Resolves:
https://fedorahosted.org/sssd/ticket/2203
---
src/db/sysdb_ops.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/db/sysdb_ops.c b/src/db/sysdb_ops.c
index 3065be6444070a8d1fceddb323cff883434eacf4..bf56c19689198de291c4e24a3d801314c23f3b31
100644
--- a/src/db/sysdb_ops.c
ACK for master
LS