On Wed, Jun 10, 2015 at 10:41:12PM +0200, Jakub Hrozek wrote:
> ==========================================================
> IPA: Utility function for setting up one-way trust context
>
> > + ad_options = ad_create_1way_trust_options(id_ctx,
> > + ad_domain,
> > +
id_ctx->server_mode->hostname,
> > + keytab,
> > + principal);
> > + if (ad_options == NULL) {
> > + talloc_free(keytab);
> > + talloc_free(principal);
> > + return NULL;
> > + }
> > +
> > + talloc_steal(ad_options, keytab);
> > + talloc_steal(ad_options, principal);
>
> Why do you have to keep keytab and principal around? They should have been
> talloc_strdup'd in ad_create_1way_trust_options.
Yes, I don't think we do.
I also squashed fixes to use forest vs forest root and pushed a new
patch.