On Mon, Apr 08, 2013 at 03:13:40PM +0200, Michal Židek wrote:
Almost ack :)
+ for (dinfo_list = tctx->domains; dinfo_list;
+ dinfo_list = get_next_domain(dinfo_list, false)) {
+ sysdb = dinfo_list->sysdb;
+ sysdb_update_subdomains(dinfo_list);
Please check the return value here, print a debug message on failure and
continue
Can you add a comment atop this block of code? It's not very easy to
understand:
+
+ if (main_domain) {
+ if (!dinfo->subdomains) {
+ /* This domain has no subdomains */
+ break;
+ }
+ main_domain = false;
+ dinfo = dinfo->subdomains;
+ } else {
+ dinfo = dinfo->next;
+ }
+ } while (dinfo);
Otherwise I'm fine with the code.