On Wed, Sep 18, 2013 at 03:38:42PM +0200, Pavel Březina wrote:
On 09/17/2013 09:59 PM, Jakub Hrozek wrote:
>On Fri, Sep 13, 2013 at 11:42:58AM +0200, Pavel Březina wrote:
>>On 09/04/2013 08:15 AM, Jakub Hrozek wrote:
>>>Hi,
>>>
>>>attached are patches that improve how we enumerate AD domains. The
>>>problem is that currently the domain info (subdomain and master domain)
>>>is downloaded when a responder queries the DP for domain info. But when
>>>enumeration is enabled, the responder might not contact the DP at all as
>>>the enumeration task runs on its own. I think the best solution is to
>>>extend the enumeration task so that it also downloads the domain data
>>>itself.
>>>
>>>About the implementation, I was considering two options. One is the way
>>>I took where the enumeration request is simply extended with downloading
>>>master domain data. The other approach I was considering was extending
>>>the generic enumeration request with downloading domain data which the
>>>generic request would just shortcut. While this might seem like a better
>>>approach, it also seemed like a complete overkill..but I'd like to hear
>>>other opinons.
>>
>>I'm agree with the approach you've chosen.
>>
>>>[PATCH 1/3] AD: async request to retrieve master domain info
>>>Adds a reusable async request to download the master domain info.
>>
>>>+++ b/src/providers/ad/ad_domain_info.c
>>>@@ -0,0 +1,350 @@
>>>+/*
>>>+ SSSD
>>>+
>>>+ AD Subdomains Module
>>
>>AD Master Domain Module?
>>
>>>This patch just splits the master domain request from the subdomain
>>>request.
>>
>>Ack.
>>
>>>[PATCH 2/3] LDAP: sdap_id_setup_tasks accepts a custom enum request
>>>AD provider will override the default with its own.
>>
>>Ack.
>>
>>>[PATCH 3/3] AD: Download master domain info when enumerating
>>>https://fedorahosted.org/sssd/ticket/2068
>>>Adds the master domain download task before the enumeration.
>>
>>Ack.
>
>Hi,
>
>thank you for the review. Attached are patches rebased on top of the
>current master and with the title of ad_domain_info.c fixed. I chose a
>more neutral approach because a subsequent patch will most probably add
>another request or extend the current one to download subdomain data and
>enable subdomain enumeration.
Ack to all patches.
Pushed all to master and sssd-1-11