On Fri, Jan 24, 2014 at 03:40:55PM +0100, Sumit Bose wrote:
On Tue, Jan 21, 2014 at 11:30:47AM +0100, Lukas Slebodnik wrote:
> ehlo,
>
> I found few unused macros: PAM_SM_AUTH, PAM_SM_ACCOUNT, PAM_SM_SESSION,
> PAM_SM_PASSWORD.
>
> In my opinion, they were proposed for the same purpose as values from
> enum sss_cli_command (SSS_PAM_AUTHENTICATE, SSS_PAM_ACCT_MGMT,
> SSS_APM_*).
>
> LS
Those macros are use as switches in
/usr/include/security/pam_modules.h but only if used together with
PAM_STATIC. Since we do not use PAM_STATIC I think it is safe to remove
them. Additionally I checked the intermediate code after the cpp run and
didn't found any difference.
ACK
bye,
Sumit
Thank you for the careful review.
Pushed to master.