On 06/04/2015 12:59 PM, Pavel Březina wrote:
[snip]
For errno, it's OK to just include errno.h. I doubt errno_t is
going to
>> move..
>
> I'm sorry I don't understand - errno.h as a standard lib header file? We
> don't have any our errno.h file, right?
> I see errno_t redefined in hbac_evaluator.c, nss_mc.h, sss_cli.h,
> util_errors.h do you prefer if I redefine it also in ipa_dyndns.h?
I think Jakub just misspelled the header file. Including util_errors.h
seems to be valid.
>
>>
>>> +
>>> +struct ipa_options;
>>> +struct be_ctx;
>> Hmm, wouldn't it be nicer to also here include the headers that
>> define/declare the structures..?
> I did it just to minimize compile times as sources including
> ipa_dyndns.h won't need to be recompiled if any of ipa_common.h,
> dp_backend.h and their nested header files get changed (unless they are
> already included of course). I also believe it makes dependencies of
> source file more obvious. But I really don't insist. I gladly change it.
Those header files don't change that often so I don't think you're
argument is reasonable. Please, include headers that are required
instead.
[snip]
OK, please see updated patches.