URL:
https://github.com/SSSD/sssd/pull/5375
Title: #5375: kcm: improve performance for large ccaches
alexey-tikhonov commented:
"""
Ouch... This is really large!
I have to re-read "kcm: store credentials list in hash table to avoid cache lookups
" and "sss_ptr_hash: fix double free for circular dependencies" patches.
Btw, don't you think it makes sense to factor out the latter into stand alone PR? It
would create additional hustle while backporting patches downstream, but that looks like
separate bugfix.
I've left a number of comments inline. Of those I'd like to highlight default hash
table size and covscan error.
Besides that my main and most important question is as follows:
Is it really worth the trouble to keep backward compatibility for the sake of existing
ccaches? That's quite a pile of code to support JSON format in kcm and encrypted
payload in "secdb"... We could simplify things a lot by dropping enc_type and
data_type entirely (perhaps alongside with secrets responder and even parts of
util/crypto).
I can imagine you have different view since you already put this effort in.
But is it at least something we could consider for a future release, when old format user
ccaches should be expired?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5375#issuecomment-733260458