URL:
https://github.com/SSSD/sssd/pull/260
Title: #260: Update sss_override.c
amitkumar50 commented:
"""
Dear Fabiano,
Huge thanks for response & consideration.
Frankly speaking I feel my short log+commit message are more to the
point & explanatory.
Your commit message does not explain complete problem=> Errorout+override.
Will add empty line between Commit Message & Explanation.
Finally its your call.
Thanks
Amit
On 05/04/2017 12:04 PM, fidencio wrote:
*@fidencio* commented on this pull request.
Amit,
Firstly, thanks for quickly wrapping up the changes.
I do have a few comments related to the commit short log and commit
message.
For the short log, I'd like to suggest something like:
"TOOLS/OVERRIDE: Error out when setting uid/gid as 0"
For the commit message, what do you think about:
"Currently sss_override silently ignores when uid/gid is set as 0. In
order to inform the user that setting uid/gid to zero is not allowed,
let's error out those cases."
May I ask what do you think about those commit short log and message?
Please, let me know because may be the case yours is cleaner (and then
we want to discuss till we have a consensus).
Also, please, add an empty line between the explanation in the commit
message and the "Resolves:" part.
Thanks a lot for the contribution and I'll follow up actually testing
your patches later Today/Tomorrow.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/SSSD/sssd/pull/260#pullrequestreview-36194074>, or
mute the thread
<
https://github.com/notifications/unsubscribe-auth/AWA8SE3FUlDlGZ-JRyLtjg6...;.
--
Thanks
Amit Kumar
!!If you stumble, get back up.
What happened yesterday, no longer matters.
Today is another day to move closer to your GOAL!!
"""
See the full comment at
https://github.com/SSSD/sssd/pull/260#issuecomment-299109420