-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 11/10/2010 10:07 AM, Sumit Bose wrote:
> I have only minor comment, please find them below ...
Why do you create a tmp_ctx on the two cases above and just use NULL
in
the following three cases? I think using NULL is sufficient in all
cases.
I've changed sysdb_custom_subtree_dn() to use NULL, but I left
sysdb_custom_dn() alone with using tmp_ctx. This is mostly just because
it reads cleaner, since there are two sanitized values in this function.
All other recommended changes are made. Thank you for the review. New
patches attached.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkzcIhYACgkQeiVVYja6o6PUKgCfcyU3P3ZDt0lt2bkCLig2LfRr
j3IAoIMpKp6vTXVrHsyQ/SUuIK2T+mTU
=53CM
-----END PGP SIGNATURE-----