On 04/04/2013 06:25 AM, Ondrej Kos wrote:
On 04/03/2013 10:39 PM, Dmitri Pal wrote:
> On 04/03/2013 07:36 AM, Ondrej Kos wrote:
>> Hi,
>>
>> Issue found by coverity, the code itself was inaccessibile.
>>
>>
https://fedorahosted.org/sssd/ticket/1857
>>
>> Patch is attached
>>
>> Ondra
>>
>>
>> _______________________________________________
>> sssd-devel mailing list
>> sssd-devel(a)lists.fedorahosted.org
>>
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>
>
> Did the unit test work work fine with this patch?
> Should be.
> I read the code but did nit run it. Seems like a visual ack.
Hi Dmitri,
Yes, the tests are running smoothly. I thoroughly investigated and
tested this part of code, and this condition would definitely take
false branch every time.
I know it is. I was just concerned about the validity of the adjustment
right above it. I think it is the correct adjustment that was added
later and thus the code after it became irrelevant but I forgot to
remove it.
>
> --
> Thank you,
> Dmitri Pal
>
> Sr. Engineering Manager for IdM portfolio
> Red Hat Inc.
>
>
> -------------------------------
> Looking to carve out IT costs?
>
www.redhat.com/carveoutcosts/
>
>
>
>
> _______________________________________________
> sssd-devel mailing list
> sssd-devel(a)lists.fedorahosted.org
>
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>
--
Thank you,
Dmitri Pal
Sr. Engineering Manager for IdM portfolio
Red Hat Inc.
-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/