URL:
https://github.com/SSSD/sssd/pull/778
Title: #778: ipa s2n: try to remove objects not found on the server
jhrozek commented:
"""
I'm afraid I see one more compilation warning:
```
/sssd/src/providers/ipa/ipa_s2n_exop.c: In function ‘s2n_remove_missing_object’:
/sssd/src/providers/ipa/ipa_s2n_exop.c:1803:24: warning: this statement may fall through
[-Wimplicit-fallthrough=]
if (ret != EOK || entry_type == BE_REQ_USER) {
/sssd/src/providers/ipa/ipa_s2n_exop.c:1807:5: note: here
case BE_REQ_GROUP:
^~~~
```
This diff fixes the warning for me:
```
diff --git a/src/providers/ipa/ipa_s2n_exop.c b/src/providers/ipa/ipa_s2n_exop.c
index 48d70780f..75a5a977f 100644
--- a/src/providers/ipa/ipa_s2n_exop.c
+++ b/src/providers/ipa/ipa_s2n_exop.c
@@ -1804,6 +1804,7 @@ static errno_t s2n_remove_missing_object(TALLOC_CTX *mem_ctx,
break;
}
/* Fallthough if BE_REQ_USER_AND_GROUP */
+ SSS_ATTRIBUTE_FALLTHROUGH;
case BE_REQ_GROUP:
if (req_input->type == REQ_INP_NAME) {
/* Expand to fully-qualified internal name */
```
"""
See the full comment at
https://github.com/SSSD/sssd/pull/778#issuecomment-473872098