On Tue, 2012-05-01 at 17:23 -0400, Simo Sorce wrote:
On Tue, 2012-05-01 at 16:32 -0400, Stephen Gallagher wrote:
> Older versions of glibc (like that on RHEL 5) do not have the
> le32toh() function exposed. We need this for handling the Active
> Directory ID-mapping, so we'll copy these macros from endian.h on
> a newer glibc.
>
> This fixes the current broken RHEL 5 builds on master.
NACK,
- please define only the ones you need
- please ad them, to a common file, a whole new file is not needed
unless you meant to keep it separated to give (C) credit, in which case
NACK, you are putting your own (C) in there.
All valid points. Corrected (and much shorter) patch attached.