On Wed, 2013-04-24 at 20:55 +0200, Sumit Bose wrote:
On Wed, Apr 24, 2013 at 02:22:42PM -0400, Stephen Gallagher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> On Wed 24 Apr 2013 02:05:55 PM EDT, Michal Židek wrote:
> > New version of the patch is attached.
> > Changes from previous iteration: - version-info set to 0:2:0 - init
> > function remains backward compatible, but it sets default oadptions
> > needed for range calculation. Non default values can be set via ded
> > setters. - sss_idmap_opts moved to private header
> This is still a backwards-incompatible break. If we were presenting a
> data structure in a public header and no longer are, it's an ABI
> break. Is there any way to avoid this?
sss_idmap_opts is introduced with this patch, it was in the public
header in the first version and Michal moved it into the private one in
the new version.
I think Steven was referring to struct sdap_idmap_slice disappearing
from src/providers/ldap/sdap_idmap.h maybe ?
However that should not be a problem as it is not a public header.
The new approach looks ok to me, anyway. Good turn around Michal.
Simo Sorce * Red Hat, Inc * New York