On Tue, Jan 24, 2012 at 10:42:14AM +0100, Pavel Březina wrote:
Dne 19.1.2012 12:31, Jakub Hrozek napsal(a):
>On Tue, Jan 17, 2012 at 05:55:49PM +0100, Pavel Březina wrote:
>>https://fedorahosted.org/sssd/ticket/1143
>>
>>Add a new responder command that will return to the caller just the
>>rule named cn=defaults.
>
>The patches look fine conceptually but I would like to have them rebased on
>top of the upcoming patches for
https://fedorahosted.org/sssd/ticket/1115
>not the other way around, it would be much easier. I'd like to send patches
>for #1115 quite soon, probably today.
Rebased patches attached.
0001: Ack
0002: Nack, please use "uid_t" for uid in "struct be_sudo_req"
I'm also not very fond of using BE_REQ_* inside the sdap_* request and
especially in the periodic update. I think we should rather try to
construct the filters on one place, maybe even before the _send
function. The "ALL" case could then be handled by "username=*"
similarly
to what we do in the LDAP provider.
0003: Ack
0004: Nack, you are leaking reply_buf in sss_sudo_send_recv_generic()
0005: Ack