On Mon, Oct 13, 2014 at 01:53:29PM +0200, Pavel Reichl wrote:
>
> On 09/29/2014 05:58 PM, Michal Židek wrote:
> >Hi,
> >
> >this patch solves the ticket:
> >https://fedorahosted.org/sssd/ticket/2361
> >
> >From the discussion on bugzilla and the ticket comments, it
> >looks like Jakub and Lukas were for changes in documentation
> >only (+ maybe warning/error if user misconfigured SSSD).
> >
> >I do not want look like I ignore the opinions of others
> >but I think the best way is to simply change the defaults
> >to the same as expected by AD backend. While I do agree
> >that users should set their id_provider option to AD
> >if they use AD backend, this option is more or less
> >AD specific, so I think it would be better to have
> >the same defaults with id_provider ldap. This
> >would also solve the small regressions that are
> >mentioned in the bugzilla (by users who do use
> >id_provider=AD and id_mapping=true).
> >
> >OTOH if this approach is disliked by other developers
> >I have no big problems with the man page + warning/error
> >solution.
> >
> >Simple patch is attached.
> >
> >Thanks,
> >Michal
> >
> >
> ACK,
>
> this patch is also useful for
https://fedorahosted.org/sssd/ticket/2117
Yes, after some discussion I don't see a disadvantage either. Users with
id_provider=ldap connected to AD will benefit from this change and users
with id_provider=ldap connected to IPA will not be hit, since they would
run with non-defaults already.
Given the NULL default has created some confusion and broke
configurations that ran fine (even if by accident a bit), I agree with
the change, too.
Pushed to master as: f834f712548db811695ea0fd6d6b31d3bd03e2a3