On Fri, May 23, 2014 at 11:56:32AM +0200, Jakub Hrozek wrote:
On Fri, May 23, 2014 at 08:31:49AM +0200, Lukas Slebodnik wrote:
> On (21/05/14 22:53), Jakub Hrozek wrote:
> >Hi,
> >
> >the attached patches implement the
> >org.freedesktop.DBus.Properties.GetAll method for retrieving primitive
> >types and their arrays.
> >
> >The patchset build on the previous set (currently still on review) that
> >implements the .Get method. The GetAll handler simply walks through the
> >existing getters and retrieves the results, storing them in a single
> >variant.
> >
> >The patches include a unit test that tests all currently supported
> >combinations of primitive types and array of primitive types.
>
> >From fc4b278c0914b2c7001393e471f4f6f0b532ba54 Mon Sep 17 00:00:00 2001
> >From: Jakub Hrozek <jhrozek(a)redhat.com>
> >Date: Wed, 21 May 2014 16:48:45 +0200
> >Subject: [PATCH 1/5] SBUS: Add utility function sbus_add_variant_to_dict
> >
> >---
> > src/sbus/sssd_dbus.h | 5 ++
> > src/sbus/sssd_dbus_properties.c | 116 ++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 121 insertions(+)
> >
> src/sbus/sssd_dbus_properties.c:287:41: error: no member named
'invoker_get_all' in
> 'struct sbus_interface_meta'
> meta->invoker_get_all);
> ~~~~ ^
> It is introduced in 4th aptch
> "SBUS: Implement org.freedesktop.DBus.Properties.GetAll for primitive
types"
>
> >From 32d84445012991dba38ee5b60f5614aca70b889d Mon Sep 17 00:00:00 2001
> >From: Jakub Hrozek <jhrozek(a)redhat.com>
> >Date: Wed, 21 May 2014 20:10:23 +0200
> >Subject: [PATCH 5/5] SBUS: Add org.freedesktop.DBus.Properties.GetAll to
> > Introspection
>
> FAIL: sbus_tests
>
> sbys_tests.log file is attached.
>
> LS
Ah, I didn't amend the test to include GetAll in introspection like I
did with Get, thanks. I'll prepare a new set.
Hi,
new patches are attached, but only the Introspection patch had changed
-- I added the GetAll XML to the unit test.