On 10/18/2012 05:02 AM, Dmitri Pal wrote:
Hello,
After previous set of patches have been committed I started working on
the last remaining piece - the merge functionality.
Re-reading the code I started some time ago I realized that at the time
I left the question of whether the config object should allow
partitioned section or not was still open.
Consider an example of the config file:
[foo]
x=1
[bar]
y=2
[foo]
z=3
Here we have an example of the case when the section is segmented or if
you look from another POW there are dup sections. So at first I thought
that it is OK to parse the file as is and have the internal config
object have two sections with same name. But after some deep thinking I
realized that it is a bad idea and creates a lot of unnecessary
complexity. So patch removes this code. This paves the way to a more
simple code in the merge function as we can assume that there are no dup
sections in the objects being merged.
I also noticed that doc build is spitting warnings so I opened a
separate ticket about it. That would be my next patch.
https://fedorahosted.org/sssd/ticket/1587
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Ack on the patch, one question though, do you have any coding style
template against which I could check this? It's obviously different from
the one used in the sssd.
Thanks
Ondrej
--
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech
phone: +420-532-294-558
cell: +420-736-417-909
ext: 82-62558
loc: 1013 Brno 1 office
irc: okos @ #brno