On Tue, Jun 03, 2014 at 08:15:36AM +0200, Lukas Slebodnik wrote:
On (02/06/14 23:19), Sumit Bose wrote:
On Sat, May 31, 2014 at 04:59:44PM +0200, Lukas Slebodnik wrote:
ehlo,
I think that the attached patches are self descriptive.
LS
Patches apply and build fine. I've run build on a few platforms without any issue, but I had none with openpam at hand.
I only have one comment on the last patch. getlogin() is not thread safe
It is https://github.com/freebsd/freebsd/blob/master/lib/libc/gen/getlogin.c lines 72:82
Are you sure it's the case on all platforms?
Here on Fedora-20 the man page says: ATTRIBUTES Multithreading (see pthreads(7)) The getlogin() function is not thread-safe. The getlogin_r() function is thread-safe.
In general I prefer foo_r() over foo() anytime.