On Mon, Feb 13, 2012 at 12:31 PM, Jakub Hrozek <jhrozek(a)redhat.com> wrote:
On Sun, Feb 12, 2012 at 12:29:36PM +0100, Marco Pizzoli wrote:
> As I reported on the mailing list:
> - sssd.conf man page does not include "autofs" and "ssh" as
supported
> services.
https://fedorahosted.org/sssd/ticket/1183
> - sssd-ldap.conf man page should have "not set" instead of
"none" as a
> default for the directive ldap_sasl_mech.
>
https://fedorahosted.org/sssd/ticket/1180
>
> Considered these are my first patches, I ask you to report to me
> everything I made wrong or possibly-doable-better so I can improve for
> future patches :-)
>
> Thanks
> Marco
Thank you very much for your contribution, Marco!
The first part is OK, but can you wrap the ssh part with a "with_ssh"
condition the way sudo and autofs are? Something like:
+ <phrase condition="with_ssh">, ssh</phrase>
This is done in order to only include the ssh specific documentation
when SSSD is configured with the "--with-ssh" switch.
Hi,
Ok, I understand and agree.
Now it's time for a second lesson of git :-)
How can I correct the patch? What steps do I have to follow?
re-clone from scratch? Editing the file again produce me a diff with
modified only one file...
Thanks
Marco