On (25/11/15 21:38), Jakub Hrozek wrote:
On Tue, Nov 24, 2015 at 03:41:47PM +0100, Lukas Slebodnik wrote:
> On (24/11/15 15:04), Jakub Hrozek wrote:
> >On Tue, Nov 24, 2015 at 02:11:10PM +0100, Lukas Slebodnik wrote:
> >> C) or directly test for "/usr/share/polkit-1/rules.d"
> >> but it could be overrriden with configure argument as other paths
> >> e.g. --with-init-dir (default /etc/rc.d/init.d)
> >> --with-environment-file (default /etc/sysconfig/sssd)
> >
> >I like this one the most. If there is no portable way of autodetecting
> >the directory, we should just add another configure-time option
> configure-time option should be enough
> end the default "/usr/share/polkit-1/rules.d" should work for most of
> distributions.
>
> I checked opensuse, debian, fedora, arch
OK, see the attached patch. Since there is a configure option, I didn't
check for the directory at all. We don't test for the presence of other
plugin directories either, so I think if the admin says 'install the
plugin here' we should just obey.
I also chose --enable and not --with because for not installing the file
--disable seems more natural to me.
From 9e60379325e67b48ba769ea2a65de4d022ea8b07 Mon Sep 17 00:00:00
2001
From: Jakub Hrozek <jhrozek(a)redhat.com>
Date: Wed, 25 Nov 2015 18:35:36 +0100
Subject: [PATCH] BUILD: Only install polkit rules if the directory is
available
---
Makefile.am | 5 ++++-
configure.ac | 4 ++++
contrib/sssd.spec.in | 3 +++
src/conf_macros.m4 | 20 ++++++++++++++++++++
4 files changed, 31 insertions(+), 1 deletion(-)
ACK
http://sssd-ci.duckdns.org/logs/job/33/89/summary.html
LS