On Mon, Jan 13, 2014 at 04:52:57PM -0500, Simo Sorce wrote:
On Mon, 2014-01-13 at 22:43 +0100, Jakub Hrozek wrote:
> ACK to the approach especially considering the future work!
>
> I'm thinking about one aspect that might be just my personal
> preference
> so I'd like to hear other opinions. I'm completely addicted to
> cscope/ctags so I wonder how to make life easier for developers now
> that
> there are source files outside srcdir. Perhaps it would be enough to
> export $SOURCEDIRS (see man cscope) set to builddir in the bashrc_sssd
> script?
>
> I really don't have any comments about the code itself.
>
Ok I need to ask.
are we thinking of changing the code generators very often ?
Initially I suspect yes, but once the dust settles around the generators
and the XML source files, then the interface would be stable.
Otherwise I would not mind having the autogenerated code committed to
the tree, and modified only when there is an actual change in the xml
file or the parsers.
This allows you to inspect changes to the generated code easily with git
diff too and also lets you find code with git grep, which I often use as
well, and would be very annoying if it failed to catch generated code.
This means generated code would stay in the srcdir and would not cause
issue with ctags/cscope either.
Normally I think generated code has no place in srcdir (after all, it's
not the source..) but in this case I think it would actually be better.