URL:
https://github.com/SSSD/sssd/pull/5375
Title: #5375: kcm: improve performance for large ccaches
alexey-tikhonov commented:
"""
Covscan error:
```
Error: CONSTANT_EXPRESSION_RESULT (CWE-569):
sssd-2.4.1/src/responder/kcm/kcmsrv_ops.c:1398: logical_vs_bitwise: The expression
"ret != 0 && ERR_NO_CREDS" is suspicious because it performs a Boolean
operation on a constant other than 0 or 1.
sssd-2.4.1/src/responder/kcm/kcmsrv_ops.c:1398: remediation: Did you intend to also
compare "ret" to "ERR_NO_CREDS"?
# 1396| } else {
# 1397| ret = kcm_op_get_cred_by_uuid_reply(crd,
state->common.op_ctx->reply);
# 1398|-> if (ret != EOK && ERR_NO_CREDS) {
# 1399| tevent_req_error(req, ret);
# 1400| return;
```
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5375#issuecomment-733062809