On Thu, Nov 22, 2012 at 10:56:32AM +0100, Jan Cholasta wrote:
On 16.11.2012 16:05, Jan Cholasta wrote:
>On 16.11.2012 09:48, Jakub Hrozek wrote:
>>On Tue, Nov 13, 2012 at 09:40:54AM +0100, Jan Cholasta wrote:
>>>>Honza agreed to take over this patch.
>>>
>>>Updated patch attached.
>>>
>>>Also created a new patch with fixes for errors reported by rpmlint.
>>>
>>>Honza
>>>
>>>--
>>>Jan Cholasta
>>
>>Patch 1 is mostly good builds on all releases we care about, there is
>>just
>>one issue I'd like to discuss on the list:
>>
>>>+%triggerun -- sssd < 1.9.90
>>>+# Save the current service runlevel info
>>>+# User must manually run systemd-sysv-convert --apply sssd
>>>+# to migrate them to systemd targets
>>>+/usr/bin/systemd-sysv-convert --save sssd >/dev/null 2>&1 ||:
>>>+
>>>+# If the package is allowed to autostart:
>>>+/bin/systemctl --no-reload enable sssd.service >/dev/null 2>&1
||:
>>>+
>>>+# Run these because the SysV package being removed won't do them
>>>+/sbin/chkconfig --del sssd >/dev/null 2>&1 || :
>>>+/bin/systemctl try-restart sssd.service >/dev/null 2>&1 || :
>>>+%else
>>>+# sysv
>>> %post
>>> /sbin/chkconfig --add %{servicename}
>>>
>>
>>The above snippet conforms to the Fedora Packaging Guidelines. However,
>>the comparison "sssd < 1.9.90" would only match pre-1.90 packages,
not
>>those that are already built from master, just before this change.
>>
>>We discussed the approach a little with Honza and came up with a simple
>>solution - bump up the release number that is currently hardcoded and
>>then
>>compare against "1.9.90.1". When we bump the version again during the
>>1.11
>>devel cycle, we could revert the release back to zero.
>>
>>Any objections?
>>
>>> From 3ee5fbe2358e29e9f3c662d3953fca3f95cefa2c Mon Sep 17 00:00:00 2001
>>>From: Jan Cholasta <jcholast(a)redhat.com>
>>>Date: Mon, 12 Nov 2012 13:00:45 -0500
>>>Subject: [PATCH 2/2] Fix errors reported by rpmlint
>>
>>Ack. I tested that the keyutils-libs requires is picked up automatically
>>by RPM. The upgrade_config.py change is also fine as the file is
>>installed outside $PATH.
>>
>
>Updated patch attached.
>
>Honza
>
Rebased both the patches on top of sssd-1-9.
Honza
--
Jan Cholasta
Ack