On (28/01/16 13:46), Michal Židek wrote:
On 01/27/2016 05:11 PM, Pavel Reichl wrote:
>
>
>On 01/27/2016 02:58 PM, Michal Židek wrote:
>>On 01/22/2016 06:38 PM, Pavel Reichl wrote:
>[snip]
>>> first_rid += ctx->idmap_opts.rangesize;
>>>@@ -631,6 +631,14 @@ get_helpers(struct sss_idmap_ctx *ctx,
>>>
>>> *_sec_slices = sec_slices;
>>> return IDMAP_SUCCESS;
>>>+
>>>+done:
>>
>>You use this goto target only case of failure. Could you
>>change it's name to 'fail'? Or alternatively you can refactor
>>the function to have single exit point and keep the done label.
>>Choice is yours.
>>
>
>OK, done.
>
Thanks.
ACK.
Link to CI:
http://sssd-ci.duckdns.org/logs/job/36/70/summary.html
It's not big problem because we use talloc with libsss_idmap
so memory would be released even in case of ENOMEM.
master:
* 5554a2a679f72f19f266d660a5681e3b0c657379
and it would be good to keed code of libraries the same
also in stable branch.
sssd-1-13:
* fe8d58c75da2b9b3704bb2ae19f8014323797757
LS