On (10/03/15 16:15), Michal Židek wrote:
Thank you Lukas.
I will not change the 'int' to 'errno_t'. We have many places
in code where we do not distinguish between the two and the
purpose of this patch is different. But I updated the
caller to use sss_strerror so that the error message is
picked up correctly.
Updated patch is attached.
Michal
From 1a593350815e62483b55c9b4d801382c7fbf0ad4 Mon Sep 17 00:00:00
2001
From: Michal Zidek <mzidek(a)redhat.com>
Date: Fri, 30 Jan 2015 15:48:04 +0100
Subject: [PATCH 1/2] Use FQDN if default domain was set
https://fedorahosted.org/sssd/ticket/2569
---
src/confdb/confdb.c | 37 +++++++++++++++++++++++++++++++++----
src/util/util_errors.c | 1 +
src/util/util_errors.h | 1 +
3 files changed, 35 insertions(+), 4 deletions(-)
ACK
http://sssd-ci.duckdns.org/logs/job/9/31/summary.html
From d7af22356db18481e0bc8a6ad503221ca154e8c7 Mon Sep 17 00:00:00
2001
From: Michal Zidek <mzidek(a)redhat.com>
Date: Tue, 3 Mar 2015 22:21:29 +0100
Subject: [PATCH 2/2] MAN: default_domain_suffix with
use_fully_qualified_names.
https://fedorahosted.org/sssd/ticket/2569
---
src/man/sssd.conf.5.xml | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/man/sssd.conf.5.xml b/src/man/sssd.conf.5.xml
index ca4e602..92c64b9 100644
--- a/src/man/sssd.conf.5.xml
+++ b/src/man/sssd.conf.5.xml
@@ -330,7 +330,10 @@
Please note that if this option is set all
users from the primary domain have to use their
fully qualified name, e.g. user(a)domain.name,
- to log in.
+ to log in. Setting this option changes default
+ of use_fully_qualified_names to True. It is not
+ allowed to use this option together with
+ use_fully_qualified_names set to False.
</para>
<para>
Default: not set
@@ -1494,7 +1497,8 @@ pam_account_expired_message = Account expired, please call help
desk.
name is requested.
</para>
<para>
- Default: FALSE
+ Default: FALSE (TRUE if default_domain_suffix is
+ used)
</para>
</listitem>
</varlistentry>
LGTM
I would like to have "review++" for man page chage from someone else.
LS